Page MenuHome Accel-ppp

Segmentation fault with latest master
On hold, LowPublicBUG

Description

Hi team
see this gdb report
Service is pppoe

Thread 7 "accel-ppp" received signal SIGSEGV, Segmentation fault.
[Switching to LWP 458195]
allocate_channel (ppp_max_payload=0, cookie=<optimized out>, tr101=0x0,
    service_name=<optimized out>, relay_sid=0x0, host_uniq=0x7fffd0002030,
    addr=0x7fffd0002022 "\374\354\332f\365\272\210c\021\031", serv=0x467ee0)
    at /build/accel-ppp-master/accel-pppd/ctrl/pppoe/pppoe.c:348
348     /build/accel-ppp-master/accel-pppd/ctrl/pppoe/pppoe.c: No such file or directory.
(gdb)
(gdb) bt full
#0  allocate_channel (ppp_max_payload=0, cookie=<optimized out>, tr101=0x0,
    service_name=<optimized out>, relay_sid=0x0, host_uniq=0x7fffd0002030,
    addr=0x7fffd0002022 "\374\354\332f\365\272\210c\021\031", serv=0x467ee0)
    at /build/accel-ppp-master/accel-pppd/ctrl/pppoe/pppoe.c:348
        conn = 0x7fffc00561b8
        old_sid_ptr = <optimized out>
        subscriber_tags = <optimized out>
        conn = <optimized out>
        old_sid_ptr = <optimized out>
        subscriber_tags = <optimized out>
        bit = <optimized out>
#1  pppoe_recv_PADR (size=<optimized out>,
    pack=0x7fffd000201c "\254\037k\365{\322\374\354\332f\365\272\210c\021\031",
    serv=0x467ee0)
    at /build/accel-ppp-master/accel-pppd/ctrl/pppoe/pppoe.c:1299
        service_name_tag = <optimized out>
        service_match = <optimized out>
        conn = <optimized out>
        vendor_id = <optimized out>
        ethhdr = 0x7fffd000201c
        hdr = 0x7fffd000202a
        tag = <optimized out>
        host_uniq_tag = 0x7fffd0002030
        ac_cookie_tag = <optimized out>
        tr101_tag = 0x0
        n = <optimized out>
        ppp_max_payload = 0
        relay_sid_tag = 0x0
        ethhdr = <optimized out>
        hdr = <optimized out>
        tag = <optimized out>
        host_uniq_tag = <optimized out>
        relay_sid_tag = <optimized out>
        ac_cookie_tag = <optimized out>
        service_name_tag = <optimized out>
        tr101_tag = <optimized out>
        n = <optimized out>
        service_match = <optimized out>
        conn = <optimized out>
        vendor_id = <optimized out>
        ppp_max_payload = <optimized out>
        svc_index = <optimized out>
#2  pppoe_serv_read (data=0x7fffd0002018 "V")
    at /build/accel-ppp-master/accel-pppd/ctrl/pppoe/pppoe.c:1348
        serv = 0x467ee0
        pack = 0x7fffd000201c "\254\037k\365{\322\374\354\332f\365\272\210c\021\031"
        hdr = 0x7fffd000202a
        n = <optimized out>
#3  0x00007ffff7880d23 in ctx_thread (ctx=<optimized out>)
    at /build/accel-ppp-master/accel-pppd/triton/triton.c:280
        call = 0x7fffc8007358
        tt = 1
        h = <optimized out>
        t = <optimized out>
        events = <optimized out>
        h = <optimized out>
        t = <optimized out>
        call = <optimized out>
        tt = <optimized out>
--Type <RET> for more, q to quit, c to continue without paging--
        events = <optimized out>
#4  triton_thread (thread=0x6310a0)
    at /build/accel-ppp-master/accel-pppd/triton/triton.c:195
        set = {__val = {516, 0 <repeats 15 times>}}
        sig = 10
        need_free = <optimized out>
        stack = 0x0
#5  0x00007ffff76f383f in ?? () from /lib64/libc.so.6
No symbol table info available.
#6  0x00007ffff777f48c in ?? () from /lib64/libc.so.6
No symbol table info available.

Details

Protocol
PPPoE
Version
1.12.0 - latest commit 3b01433a2e00a3489fc2a746078d79530a450015

Event Timeline

micron triaged this task as High priority.Oct 2 2021, 16:57
micron created this task.

i send tcpdump cap to @Dimka88 on time of problem.

part of tcpdump :

ac:1f:6b:f5:7b:d2 > fc:ec:da:66:f5:ba, PPPoE D, length 42: PPPoE PADT [ses 0xd440] [AC-Name "ETEST"] [Service-Name "etest"]
fc:ec:da:66:f5:ba > ac:1f:6b:f5:7b:d2, PPPoE D, length 86: [type 6]PPPoE PADR [Host-Uniq 0xA047D70CF6D8000005000600] [AC-Cookie 0x4973E9E298F8F5230123C452F2CAC08F1F275BBAA5BBBD8D] [AC-Name "ET.EST"] [Service-Name "etest"]
fc:ec:da:66:f5:ba > ff:ff:ff:ff:ff:ff, PPPoE D, length 60: PPPoE PADI [Host-Uniq 0xA047D70CF6D8000005020600] [TAG-0x1101 "epcit.l"]
ac:1f:6b:f5:7b:d2 > fc:ec:da:66:f5:ba, PPPoE D, length 96: PPPoE PADO [AC-Name "ETEST"] [Service-Name "etest"] [Service-Name "den_01"] [AC-Cookie 0x4973E9E298F8F5230123C452F2CAC08F4176B1EF29091EF2] [Host-Uniq 0xA047D70CF6D8000005020600]
fc:ec:da:66:f5:ba > ac:1f:6b:f5:7b:d2, PPPoE D, length 86: PPPoE PADR [|pppoe]
fc:ec:da:66:f5:ba > ac:1f:6b:f5:7b:d2, PPPoE D, length 86: PPPoE PADR [Host-Uniq 0xA047D70CF6D8000005020600] [AC-Cookie 0x4973E9E298F8F5230123C452F2CAC08F447671EF29091EF2] [AC-Name "ETEST\"] [TAG-0x501 "etest"]
fc:ec:da:66:f5:ba > ac:1f:6b:f5:7b:d2, PPPoE D, length 87: PPPoE PADR [Host-Uniq 0xA047DB0CF6D8000005020600] [AC-Cookie 0x4973E9E298F8F5230123C452F2CAC08F4176B1EF29091EF2] [AC-Name "ETEST"] [Service-Name "etest"]
fc:ec:da:66:f5:ba > ac:1f:6b:f5:7b:d2, PPPoE D, length 86: PPPoE PADR [Host-Uniq 0xA047D70CF6D8000005020600] [AC-Cookie 0x4973C9E298F8F5230123C452F2CAC08F4176B1EF29091EF2] [AC-Name "ETEST"] [Service-Name "etest"]
fc:ec:da:66:f5:ba > ac:1f:6b:f5:7b:d2, PPPoE D, length 86: PPPoE PADR [Host-Uniq 0xA047D70CF6D8000005020600] [AC-Cookie 0x4973E92298F8F5230123C452F2DACA8F4176B1EF29091EF2] [AC-Name "ETEST"] [|pppoe]
fc:ec:da:66:f5:ba > ff:ff:ff:ff:ff:ff, PPPoE D, length 60: PPPoE PADI [Host-Uniq 0xA047D70C06D8000005020600] [Service-Name "etest"]
fc:ec:da:66:f5:ba > ff:ff:ff:ff:fd:ff, PPPoE D, length 60: PPPoE PADI [Host-Uniq 0xA047D70CF6D8000005020600] [Service-Name "etest"]
fc:ec:da:66:f5:ba > ff:ff:ff:ff:ff:ff, PPPoE D, length 60: PPPoE PADI [Host-Uniq 0xA047D70CF6D8000005020600] [Service-Name "etest"]
fc:ec:da:66:f5:ba > ff:ff:ff:ff:ff:ff, PPPoE D, length 61: PPPoE PAD-61 [Host-Uniq 0xA047D70EF6D8000005020600] [Service-Name "e.est"] [|pppoe]
fc:ec:da:66:f5:ba > ff:ff:ff:ff:ff:ff, PPPoE D, length 62: PPPoE PADI [Host-Uniq 0xA047D70CF6D8000005020600] [|pppoe]

And last line from debug.log:

[2021-10-02 20:46:39.905] vlan1467: recv [PPPoE PADR fc:ec:da:66:f5:ba => ac:1f:6b:f5:7b:d2 sid=0000 <Host-Uniq a047d70cf6d8000005020600> <AC-Cookie 7c59a0a51bdb97a6cc6766d7a2c1edf70c16e2ba313d424a> <AC-Name ETEST> <Unknown (401)>]

Hi @micron , did you modify the accel-ppp code by yourself, exactly functions related to Service-Name?

no in this case work with latest master and after this segfault not see this problem.
may be is network problem send wrong package

Dimka88 changed the task status from Open to On hold.Dec 17 2021, 22:10

Unfortunately, I can not reproduce this issue, please reopen this ticket when this issue will appear again.

Dimka88 lowered the priority of this task from High to Low.Jan 26 2022, 11:50